Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Create coordinate objects" how-to guide should show how to creat coordinate with custom observer #7151

Open
wtbarnes opened this issue Aug 16, 2023 · 5 comments
Open

"Create coordinate objects" how-to guide should show how to creat coordinate with custom observer #7151

wtbarnes opened this issue Aug 16, 2023 · 5 comments
Labels
Documentation Affects the documentation Effort Low Requires a small time investment Feature Request New feature wanted! Good First Issue The best issues for new people to tackle! Package Novice Requires little knowledge of the internal structure of SunPy Priority Low Slow action required

Comments

@wtbarnes
Copy link
Member

Describe the feature

In the how-to guide for creating coordinate objects, we only show how to create coordinates with observer='earth'. We should also show an example of how to create an observer from a custom SkyCoord.

Proposed solution

No response
@wtbarnes wtbarnes added Feature Request New feature wanted! Documentation Affects the documentation labels Aug 16, 2023
@nabobalis nabobalis added Package Novice Requires little knowledge of the internal structure of SunPy Priority Low Slow action required Effort Low Requires a small time investment Good First Issue The best issues for new people to tackle! labels Mar 20, 2024
@PaoloBiolghini
Copy link

PaoloBiolghini commented Mar 21, 2024 •
edited

Is it correct to say that a observer can be or None or default value "hearth" or a anySkycoord object (preferibly of type HeliographicStonyhurst) that can be parsed by get_body_heliographic_stonyhurst at the time obstime?

@nabobalis
Copy link
Contributor

I would assume the SkyCoord would not be passed to get_body_heliographic_stonyhurst since it only takes a string as input.

@PaoloBiolghini
Copy link

so one point of any type of coordinates system that could be paresd with get_body_heliographic_stonyhurst right?

@nabobalis
Copy link
Contributor

No? If I recall the observer can be any Skycoord object.

@PaoloBiolghini
Copy link

PaoloBiolghini commented Mar 22, 2024 •
edited

Should i write and example for the observer not just for the helioprojective frame right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Affects the documentation Effort Low Requires a small time investment Feature Request New feature wanted! Good First Issue The best issues for new people to tackle! Package Novice Requires little knowledge of the internal structure of SunPy Priority Low Slow action required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nabobalis @wtbarnes @PaoloBiolghini