Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Divide up and remove sunpy.physics.differential_rotation #7161

Open
ayshih opened this issue Aug 21, 2023 · 1 comment
Open

Divide up and remove sunpy.physics.differential_rotation #7161

ayshih opened this issue Aug 21, 2023 · 1 comment
Labels
coordinates Affects the coordinates submodule Effort Medium Requires a moderate time investment map Affects the map submodule physics Affects the physics submodule Priority Medium Non-urgent action required Refactoring Code changes without affecting API (generally)

Comments

@ayshih
Copy link
Member

ayshih commented Aug 21, 2023 •
edited

sunpy.physics.differential_rotation is the only module in that sub-package, and contains three items, each of which has a more appropriate place to live:

  • diff_rot(), which can be moved to sunpy.sun.models
  • solar_rotate_coordinate(), which can be moved to sunpy.coordinates.utils
  • differential_rotate(), which can be moved to sunpy.map.maputils

Then we can get rid of sunpy.physics.differential_rotation (after deprecation), and thus sunpy.physics as well.
@ayshih ayshih added Refactoring Code changes without affecting API (generally) map Affects the map submodule coordinates Affects the coordinates submodule physics Affects the physics submodule Priority Medium Non-urgent action required Effort Medium Requires a moderate time investment labels Aug 21, 2023
@NucleonGodX
Copy link
Contributor

I'd try to work on this one!

@Ghaithq Ghaithq mentioned this issue Jan 24, 2024
Closed
@ayshih ayshih mentioned this issue Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
coordinates Affects the coordinates submodule Effort Medium Requires a moderate time investment map Affects the map submodule physics Affects the physics submodule Priority Medium Non-urgent action required Refactoring Code changes without affecting API (generally)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ayshih @NucleonGodX