Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure text contrast on Map notebook repr is very low on dark background #7559

Open
dstansby opened this issue Apr 7, 2024 · 1 comment
Open

Figure text contrast on Map notebook repr is very low on dark background #7559

dstansby opened this issue Apr 7, 2024 · 1 comment
Labels
Bug Probably a bug Effort Medium Requires a moderate time investment map Affects the map submodule Package Novice Requires little knowledge of the internal structure of SunPy Priority Low Slow action required

Comments

@dstansby
Copy link
Member

dstansby commented Apr 7, 2024 •
edited

Describe the bug

The contrast on the figure text is very low against a dark background:
Screenshot 2024-04-07 at 18 40 23

This is viewing in VSCode

To Reproduce

No response

Screenshots

No response

System Details

No response

Installation method

No response
@dstansby dstansby added the Bug Probably a bug label Apr 7, 2024
@dstansby dstansby changed the title Text contrast on Map notebook repr is very low on dark background Figure text contrast on Map notebook repr is very low on dark background Apr 7, 2024
@nabobalis nabobalis added Package Novice Requires little knowledge of the internal structure of SunPy map Affects the map submodule Priority Low Slow action required Effort Medium Requires a moderate time investment labels Apr 7, 2024
@ayshih
Copy link
Member

ayshih commented Apr 8, 2024

This is really a separate bug, but also the image shouldn't look like that (irrespective of theme). As a histogram-equalized image, it should be using black and dark grays...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Probably a bug Effort Medium Requires a moderate time investment map Affects the map submodule Package Novice Requires little knowledge of the internal structure of SunPy Priority Low Slow action required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ayshih @nabobalis @dstansby