Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Things to fix when numpy 2.0 is out #7566

Open
nabobalis opened this issue Apr 10, 2024 · 0 comments
Open

Things to fix when numpy 2.0 is out #7566

nabobalis opened this issue Apr 10, 2024 · 0 comments
Labels
Effort Low Requires a small time investment Infrastructure Issues or PRs that affect the CI or packaging of SunPy Package Novice Requires little knowledge of the internal structure of SunPy Priority Low Slow action required

Comments

@nabobalis
Copy link
Contributor

nabobalis commented Apr 10, 2024 •
edited

In #7556 we skip several doc tests to handle the fact the output is different verus numpy 2.0 and numpy < 2.0

These need to be un skipped and for the oldest deps build, a conditional tweak to the doctest to either skip them on numpy <2.0

This also includes several tests that read CDF files that now fail under numpy 2.0. We need to wait for cdflib to support numpy and we can unskip those as well.
@nabobalis nabobalis changed the title We should open a tracking issue for when numpy 2.0 is released to un-skip these (and anything else which will need fixing). Things to fix when numpy 2.0 is out Apr 10, 2024
@nabobalis nabobalis added Package Novice Requires little knowledge of the internal structure of SunPy Priority Low Slow action required Effort Low Requires a small time investment Infrastructure Issues or PRs that affect the CI or packaging of SunPy labels Apr 10, 2024
@nabobalis nabobalis mentioned this issue Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Effort Low Requires a small time investment Infrastructure Issues or PRs that affect the CI or packaging of SunPy Package Novice Requires little knowledge of the internal structure of SunPy Priority Low Slow action required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nabobalis