Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_dummy_map_from_header useful outside of core #7608

Open
Cadair opened this issue Apr 30, 2024 · 0 comments
Open

Make get_dummy_map_from_header useful outside of core #7608

Cadair opened this issue Apr 30, 2024 · 0 comments
Labels
Bug Probably a bug data Affects the data submodule Effort Low Requires a small time investment Package Novice Requires little knowledge of the internal structure of SunPy Priority Medium Non-urgent action required

Comments

@Cadair
Copy link
Member

Cadair commented Apr 30, 2024

Describe the bug

Our get_dummy_map_from_header helper would be useful outside of core (I was trying to use it in sunkit-magex), but because of how it looks up the filename:

if isinstance(filename, Path):
# NOTE: get_pkg_data_filename does not accept Path objects
filename = filename.as_posix()
return get_pkg_data_filename(filename, package="sunpy.data.test", **kwargs)

it doesn't work unless the file is in the sunpy repo.

To Reproduce

No response

Screenshots

No response

System Details

No response

Installation method

No response

@Cadair Cadair added the Bug Probably a bug label Apr 30, 2024
@nabobalis nabobalis added Package Novice Requires little knowledge of the internal structure of SunPy Priority Medium Non-urgent action required Effort Low Requires a small time investment data Affects the data submodule labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Probably a bug data Affects the data submodule Effort Low Requires a small time investment Package Novice Requires little knowledge of the internal structure of SunPy Priority Medium Non-urgent action required
Projects
None yet
Development

No branches or pull requests

2 participants