New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Spice Reader functions #173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meta objects must be dict-like to work with astropy nddata.
DanRyanIrish
force-pushed
the
spice
branch
2 times, most recently
from
October 5, 2020 17:31
db7d1c2
to
726167f
Compare
nabobalis
reviewed
Oct 5, 2020
tox.ini
Outdated
@@ -73,6 +76,8 @@ extras = docs | |||
commands = | |||
sphinx-build --color -W --keep-going -b html -d _build/.doctrees . _build/html {posargs} | |||
python -c 'import pathlib; print("Documentation available under file://\{0\}".format(pathlib.Path(r"{toxinidir}") / "docs" / "_build" / "index.html"))' | |||
deps = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
deps = | |
deps = |
DanRyanIrish
force-pushed
the
spice
branch
5 times, most recently
from
October 6, 2020 10:53
b8b83d4
to
829e66c
Compare
…ce with array_axis_physical_types versions.
DanRyanIrish
force-pushed
the
spice
branch
4 times, most recently
from
November 3, 2020 14:04
9a35b57
to
9b55c22
Compare
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides functions to reader SPICE files.
It also refactors the
Meta
object to be dict-like. This is required byastropy.nddata
.