Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get subjective names #5

Open
mixmix opened this issue May 24, 2019 · 2 comments
Open

get subjective names #5

mixmix opened this issue May 24, 2019 · 2 comments

Comments

@mixmix
Copy link

mixmix commented May 24, 2019

Hi all, I've just patchql based name getting working in patchbay, which is a buzz!

What I want to re-implement is the ability to have subjective names. i.e. I've renamed someone, and I want that to be the name that I see.

I can see abouts are getting figured out here :
https://github.com/sunrise-choir/ssb-patchql/blob/master/src/db/models/abouts.rs#L86-L106

I can kinda see how you would just maybe skip .filter(messages_author_id.eq(author_id)) , but not really sure where to go beyond there. Would want :

  • the most recent about by each butt
  • to return something like an Object of opinions about feedX :
{
  feedA: { name: 'The Real Piet' },
  feedB: { name: 'Fake piet' },
  feedB: { name: 'Piet'}
}

obviously I don't know what data structures make sense. I'm kind of assuming that it would be good to leave it to devs to decide how to reduce these opinions so the graphql could end up looking like :

{
  author(id: FeedId) {
    name: String,  // what's currently there

    names: {
      edges {
        node {
          author: Author,
          name: String
        }
      }
    }
  }
}
@pietgeursen
Copy link
Member

Just leaving a note here after our discussion yesterday @mixmix .
I think we decided that adding the ability to include names for someone if the author of the name is followed by the namer. Eg.

Piet follows Mix. Mix names Piet. Include Mix's nickname for Piet.

I have the opinion that when displaying an Author's name in the ui should be their self assigned name. But I can see that there are times where it's useful, eg for suggestion boxes.

@mixmix
Copy link
Author

mixmix commented May 28, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants