-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug rpc server #4
Conversation
@@ -46,7 +46,7 @@ func NewNetwork(t testing.TB, cfg *Config) (cctx Context, rpcAddr, grpcAddr stri | |||
require.NoError(t, err) | |||
|
|||
t.Cleanup(func() { | |||
t.Log("tearing down testnode") | |||
// t.Log("tearing down testnode") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This log is mixed when errors occur.
ex.
--- FAIL: TestMaliciousTestNode (4.25s)
/home/user/github.com/sunrise-zone/sunrise-app/test/util/malicious/app_test.go:85:
Error Trace: /home/user/github.com/sunrise-zone/sunrise-app/test/util/malicious/app_test.go:85
Error: Received unexpected error:
tx failed with code 2: tx parse error
Test: TestMaliciousTestNode
/home/user/github.com/sunrise-zone/sunrise-app/test/util/malicious/network.go:49: tearing down testnode
/test/util/malicious/network.go is temp file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No log is required if successfully tearing down.
No description provided.