fix: jsonpb unmarshal #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibc forward.go
kimurayu45z
requested changes
Jul 19, 2024
proto/sunrise/swap/metadata.proto
Outdated
| message SwapMetadata { | ||
| string interface_provider = 1; | ||
| Route route = 2; | ||
| oneof swap_type { |
There was a problem hiding this comment.
Can you rename to amount_strategy?
There was a problem hiding this comment.
The word strategy is a little unnatural, but it's better than swap_type, i think.
mode or type is less unnatural.
kimurayu45z
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview