Ground work for libstd (reuse Xargo) #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orycterope
previously approved these changes
Aug 6, 2019
|
For posterity's sake: Cargo is working on bringing an MVP of std-aware cargo (which will replace xargo/cargo-xbuild in the future) literally right now: rust-lang/cargo#7216. Unfortunately, it won't be usable by us for a little while, but we should keep a close eye on these development. |
roblabla
requested changes
Aug 6, 2019
Orycterope
reviewed
Aug 7, 2019
marysaka
force-pushed
the
feature/xargo-in-the-past
branch
from
d1c1fe9
to
b2a5da5
Compare
Orycterope
approved these changes
Aug 24, 2019
added 3 commits
August 28, 2019 15:55
This is the preparing steps for starting our own libstd.
marysaka
force-pushed
the
feature/xargo-in-the-past
branch
from
b2a5da5
to
cc5bf90
Compare
roblabla
requested changes
Aug 29, 2019
Xargo.toml
Outdated
| stage = 0 | ||
|
|
||
| [dependencies.compiler_builtins] | ||
| version = "*" |
There was a problem hiding this comment.
Is specifying a version necessary? If it is, we should hardcode a version (Like "=x.y.z") to avoid having the build breaking because of future incompatible versions.
roblabla
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the preparing steps for starting our own libstd.