Search config in home and config directories #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that I think about it, if we are searching in the parents of the current working dir it will reach $HOME anyway 🤔 |
sunsided
requested changes
Jul 18, 2023
There was a problem hiding this comment.
Thanks, that's very useful! I only have one change request related to how the user directories are handled.
Edit: Just see now that you commented on the same note. 😅 Don't assume the .config dir is necessarily under $HOME, so keep both of them, but I'd suggest to not loop through their parents - so the scan should be:
- Current directors, or
- parents of current directory, or
- home directory, or
- config directory.
I'd go for home first since that seems to take precedence over the more "hidden" config directory on *nix.
|
Merged and released in 0.3.0. |
sunsided
added a commit
that referenced
this pull request
Jul 18, 2023
Co-authored-by: Philipp Popov <philolippo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR will add two more directories in which the config will be searched if not found in the current working dir and it's parents.
It will look for config in
$HOMEif the env var is present and also$XDG_HOME_CONFIGor$HOME/.config