Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3 and 3.1 #1034

Merged
merged 8 commits into from
Jun 26, 2023
Merged

Ruby 3 and 3.1 #1034

merged 8 commits into from
Jun 26, 2023

Conversation

s4na
Copy link
Contributor

@s4na s4na commented Jun 21, 2023

Hello,

I've taken over this PR (#1027) to adapt Sunspot for use with Ruby 3 and Ruby 3.1.

Permission has been obtained from @njakobsen

refs: #1027 (comment)

@s4na
Copy link
Contributor Author

s4na commented Jun 22, 2023

It seems that the test didn't fail, but rather the GitHub Actions Job failed to launch. Could you please retry the GitHub Actions?

https://github.com/sunspot/sunspot/actions/runs/5333568890/jobs/9664209033?pr=1034

Screenshot 2023-06-22 at 10 09 38

@s4na
Copy link
Contributor Author

s4na commented Jun 26, 2023

@serggl
Could I possibly get a review?

Copy link
Collaborator

@serggl serggl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@serggl serggl merged commit 678c5b2 into sunspot:master Jun 26, 2023
31 checks passed
@serggl serggl mentioned this pull request Jun 26, 2023
@njakobsen
Copy link
Contributor

@s4na Thanks for bringing this one home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants