Add Ruby 3.2, 3.3, HEAD to CI matrix #1042
Conversation
ci/sunspot_test_script.sh
Outdated
| bundle install --quiet --path vendor/bundle | ||
|
|
||
| if [ "$(printf "%s\n" "3.2" "$RUBY_VERSION" | sort -V | tail -n1)" = "$RUBY_VERSION" ]; then | ||
| bundle config set --local path 'vendor/bundle' |
There was a problem hiding this comment.
@s4na can you explain the purpose of this conditional? would bundle config set + bundle install work the same way for all ruby versions?
There was a problem hiding this comment.
if this works the same way, then the conditional can be removed, right?
There was a problem hiding this comment.
@s4na left few more questions. I see you removed development dependencies version constraints. Although I see test suite is passing, this might broke at some time in the future. I would vote to still pin gems to some explicit versions (latest at the moment)
ci/sunspot_test_script.sh
Outdated
| bundle install --quiet --path vendor/bundle | ||
|
|
||
| if [ "$(printf "%s\n" "3.2" "$RUBY_VERSION" | sort -V | tail -n1)" = "$RUBY_VERSION" ]; then | ||
| bundle config set --local path 'vendor/bundle' |
There was a problem hiding this comment.
if this works the same way, then the conditional can be removed, right?
sunspot_rails/sunspot_rails.gemspec
Outdated
| @@ -30,13 +30,15 @@ Gem::Specification.new do |s| | |||
| s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } | |||
| s.require_paths = ["lib"] | |||
|
|
|||
| s.add_dependency 'rails', '>= 5' | |||
| s.add_dependency 'rails' | |||
There was a problem hiding this comment.
why was the restriction removed removed?
|
@serggl |
| @@ -25,12 +25,12 @@ Gem::Specification.new do |s| | |||
| s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } | |||
| s.require_paths = ["lib"] | |||
|
|
|||
| s.add_dependency 'rsolr', '>= 1.1.1', '< 3' | |||
| s.add_dependency 'rsolr', '>= 1.1.1', '< 2.6' | |||
There was a problem hiding this comment.
Since RSolr 2.6 is causing errors, it needs to be addressed in a separate PR.
.github/workflows/ci.yml
Outdated
| build: | ||
| needs: skip_concurrent_build | ||
| if: ${{ needs.skip_concurrent_build.outputs.should_skip != 'true' }} |
There was a problem hiding this comment.
@s4na would you mind bringing this back? I'm totally fine merging this afterwards
|
Thank you |
No description provided.