add skip_index feature

[dkln]

as promised... a seperate commit for skip_index! feature ;)

[rposborne]

+1

[brutuscat]

Why would you like to skip index? Why this is not enough? A use case would be nice :D

searchable :auto_index => false, :auto_remove => false do
...
end

Then you handle indexing as you want using whatever callback you needed.

[dkln]

because most of the times you want to auto_index all your search objects... except when you are, for example, importing a big bulk of data that runs in a transaction... when the import is finished you want to manually reindex all the data

[brutuscat]

I that case wouldn't be better to have a scoped block for that? Much like it is done in ActiveRecord::Base.uncached?

[dkln]

why a scoped block when you can do it in just one statement?

[brutuscat]

Because that way you scope the special behavior. Then it wil be very clear for others reading your code that you explicitly wanted to skip the Sunspot indexing on that particular lines of code.

[dkln]

ah I see :) not a bad idea!

[brutuscat]

It also would be great to have one spec asserting that code in that block doesn't trigger indexing ;)

[brupm]

Would you mind adding a test? Thanks.

[nz]

I like the idea of selectively disabling the auto-indexing behavior, but this pull request seems to be lacking specs and a usage example, as well as consensus on what that usage should look like.

Something like this will probably come up again in the future, so I am going to close this for now. Feel free to reopen with better specs and docs.

In theory I'd love to toggle Sunspot's auto-indexing on and off with something like the following…

Sunspot.auto_index = false

# or

Sunspot.disable_auto_indexing do
  # Create a ton of records...
end

But the usefulness of this behavior really is better paired with a deeper rethink of how and when indexing happens.