Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make InRadius restriciton use GeoFilt class #517

Closed
wants to merge 1 commit into from

Conversation

brandonwestcott
Copy link
Contributor

This is mainly to allow q.without(:geo).in_radius(32, -68, 10, bbox: true) functionality. That is, the use of bbox on without queries.

Also, since the Sunspot::Query::Geofilt already has the responsibility of generating the geofilt function for other types of queries, it makes sense to have InRadius use the same code and logic.

@brandonwestcott
Copy link
Contributor Author

I also just found that facets with an .in_radius query also use the InRadius class. Therefore, this PR would also allow the use of bbox: true in a facet query.

@njakobsen
Copy link
Contributor

Do you mind making note of this additional functionality in the readme?

@sunspot sunspot deleted a comment from ma2kubo Feb 22, 2021
@sunspot sunspot deleted a comment from ma2kubo Feb 22, 2021
@sunspot sunspot deleted a comment from ma2kubo Feb 22, 2021
@mlh758 mlh758 closed this Feb 22, 2021
@mlh758
Copy link
Collaborator

mlh758 commented Feb 22, 2021

Closed this due to age. Can reopen if there is still interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants