Extract ID prefix into a separate method. #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serggl
reviewed
Jul 29, 2019
sunspot/lib/sunspot/adapters.rb
Outdated
| # ==== Returns | ||
| # | ||
| # String:: ID prefix for use in index ID to control shards | ||
| # a document ise stored on |
There was a problem hiding this comment.
Whoops, yes, will fix now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful sometimes to get record's ID prefix from third-party libraries.
For example, we use an index queue for background indexing and it uses
Sunspot.remove_by_id, which stops working once we add an ID prefix, because in the index we getUSA!Profile 123whileremove_by_idtries to removeProfile 123.