Fix backwards compatibility loading engine models on Rails 3.0 #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbngzlv
force-pushed
the
fix_backwards_compatibility_rails_3.0
branch
2 times, most recently
from
81bfe49
to
03da66e
Compare
rbngzlv
force-pushed
the
fix_backwards_compatibility_rails_3.0
branch
from
03da66e
to
107fa0a
Compare
rbngzlv
force-pushed
the
fix_backwards_compatibility_rails_3.0
branch
from
107fa0a
to
01b5746
Compare
|
Hi @serggl, sorry for mentioning you directly, can you take a look at this PR? Or can you direct this PR to another team member? Thank you. |
gr8bit
added a commit
to bichinger/sunspot
that referenced
this pull request
Feb 28, 2021
…update * 'v3-dev' of github.com:sunspot/sunspot: update formating to eager loading guide in README (sunspot#996) Fix backwards compatibility loading engine models on Rails 3.0 (sunspot#972) Adding correct link for readme resource under Tutorials and Articles section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
As mentioned in the issue #739, the rake task
sunspot:reindexfails on Rails 3.0, because theinstancemethod on theEngineis not implemented in this version.The error is:
The offending line is:
sunspot/sunspot_rails/lib/sunspot/rails/tasks.rb
Line 34 in aa236c1
But is possible that this line isn't really needed? I added a spec to check that engine models are loaded, can somebody else take a look?
And thank you all for the work on the gem!