Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support keys G to L in menus #25

Merged

Conversation

olafkryus
Copy link
Contributor

@olafkryus olafkryus commented Feb 20, 2024

Menus rely on number keys for quick navigation. Press the number key corresponding to the menu item position and the menu cursor instantly moves there. Since some menus have more than 9 positions, additional letter keys A-F are supported. However, this makes little sense to me.

The only menu in which the menu positions past number 9. are displayed as "lettered" – A., B. etc., as opposed to regular numbering from 10. upwards – is the "Jumping options" screen of the Setup menu. But it only goes up to the letter B. However, this "letter-key-navigation" method works in all kinds of menus, even the "regularly-numbered" ones, and some of them go up to 20 positions (e.g. Jumpers menu, Practise jump menu). I see no reason to stop at F in particular, the menu item has nothing to do with the hexadecimal world, and not all players are programmers 😉

This pull requests increases letter-key range from A..F to A..K in order to facilitate quick navigation for all 20 possible menu items.

Edit: Actually, having custom hills extends Practise jump menu to 21 items ("More hills…" options is added), so I've extended the range to A..L

@olafkryus olafkryus changed the title Support keys G to K in menus Support keys G to L in menus Feb 21, 2024
Copy link
Member

@veikkos veikkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@veikkos veikkos merged commit 6b8c5db into suomipelit:master Apr 6, 2024
@veikkos veikkos changed the title Support keys G to L in menus Support keys A to L in menus Apr 7, 2024
@veikkos veikkos changed the title Support keys A to L in menus Support keys G to L in menus Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants