Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hdlcc standalone profiling not useful #16

Closed
suoto opened this issue Mar 28, 2016 · 1 comment
Closed

hdlcc standalone profiling not useful #16

suoto opened this issue Mar 28, 2016 · 1 comment
Assignees
@suoto
Labels
enhancement
Milestone
Backlog

Comments

@suoto
Copy link
Owner

suoto commented Mar 28, 2016

hdlcc standalone profiling results are not useful because the work itself is done inside another thread.

Current results look like this:
image

CI tests only catch if the switch works, it doesn't checks the profiling output itself.
@suoto suoto self-assigned this Mar 28, 2016
@suoto suoto added this to the Backlog milestone Mar 28, 2016
suoto added a commit that referenced this issue Apr 5, 2016
@suoto
Adding workaround for #16
55298d3
@suoto suoto added ready and removed ready labels Apr 5, 2016
@suoto suoto mentioned this issue Apr 14, 2016
Merged
@suoto
Copy link
Owner Author

suoto commented Apr 14, 2016

PR #23 fixes this by disabling threads on standalone hdlcc.

@suoto suoto closed this as completed Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suoto suoto

Labels
enhancement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@suoto