Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Solid Account Selector #66

Merged
merged 2 commits into from
May 25, 2013

Conversation

5long
Copy link
Contributor

@5long 5long commented May 23, 2013

  • Raise exception early when setting to an unknown value
  • Don't set unknown account when editing mail.

This should fix #65. But the code turns ugly: caller of HorizontalSelector#set_to has to look before leap.

Needs to be backported to line-0.13-develop as well

5long added 2 commits May 24, 2013 01:18
* #set_to() should raise error when receiving unknown value
* Implement #can_set_to?
* Unit test for #set_to, #val and #can_set_to?
@gauteh
Copy link
Member

gauteh commented May 23, 2013

👍

1 similar comment
@ericweikl
Copy link
Contributor

👍

5long added a commit that referenced this pull request May 25, 2013
@5long 5long merged commit aa09969 into sup-heliotrope:develop May 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when setting From email address when returning from edit new message
3 participants