fix: get recovery mode before notify sign in event

supabase/auth-js@9c0f42b
supabase-community · Dec 2, 2021 · 4ef96ce · 4ef96ce
1 parent 19f4556
commit 4ef96ce
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/gotrue/_async/client.py b/gotrue/_async/client.py
@@ -431,8 +431,9 @@ async def get_session_from_url(
         )
         if store_session:
             await self._save_session(session=session)
+            recovery_mode = query.get("type")
             self._notify_all_subscribers(event=AuthChangeEvent.SIGNED_IN)
-            if query.get("type") == "recovery":
+            if recovery_mode == "recovery":
                 self._notify_all_subscribers(event=AuthChangeEvent.PASSWORD_RECOVERY)
         return session
 

diff --git a/gotrue/_sync/client.py b/gotrue/_sync/client.py
@@ -429,8 +429,9 @@ def get_session_from_url(self, *, url: str, store_session: bool = False) -> Sess
         )
         if store_session:
             self._save_session(session=session)
+            recovery_mode = query.get("type")
             self._notify_all_subscribers(event=AuthChangeEvent.SIGNED_IN)
-            if query.get("type") == "recovery":
+            if recovery_mode == "recovery":
                 self._notify_all_subscribers(event=AuthChangeEvent.PASSWORD_RECOVERY)
         return session