Skip to content

Commit

Permalink
Merge pull request #264 from lmoj/double-urlencode
Browse files Browse the repository at this point in the history
fix issue #246
  • Loading branch information
J0 committed May 25, 2023
2 parents 0efdd9d + 034da90 commit dca7d9a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
5 changes: 2 additions & 3 deletions gotrue/_async/gotrue_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from json import loads
from time import time
from typing import Callable, Dict, List, Tuple, Union
from urllib.parse import parse_qs, quote, urlencode, urlparse
from urllib.parse import parse_qs, urlencode, urlparse
from uuid import uuid4

from ..constants import (
Expand Down Expand Up @@ -829,8 +829,7 @@ def _get_url_for_provider(
provider: Provider,
params: Dict[str, str],
) -> str:
params = {k: quote(v) for k, v in params.items()}
params["provider"] = quote(provider)
params["provider"] = provider
query = urlencode(params)
return f"{self._url}/authorize?{query}"

Expand Down
5 changes: 2 additions & 3 deletions gotrue/_sync/gotrue_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from json import loads
from time import time
from typing import Callable, Dict, List, Tuple, Union
from urllib.parse import parse_qs, quote, urlencode, urlparse
from urllib.parse import parse_qs, urlencode, urlparse
from uuid import uuid4

from ..constants import (
Expand Down Expand Up @@ -827,8 +827,7 @@ def _get_url_for_provider(
provider: Provider,
params: Dict[str, str],
) -> str:
params = {k: quote(v) for k, v in params.items()}
params["provider"] = quote(provider)
params["provider"] = provider
query = urlencode(params)
return f"{self._url}/authorize?{query}"

Expand Down

0 comments on commit dca7d9a

Please sign in to comment.