This repository has been archived by the owner on May 13, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in GoTrue PR - supabase/auth#245
Rename `confirmed_at` so that email and phone confirmed at can be added. Also add the phone number field.
dshukertjr
suggested changes
Oct 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for an amazing PR 🎉🎉🎉
I did leave a comment about one little thing. Please let me know what you think!
Any estimate to when this will be merged? |
Sorry @DriesCruyskens for taking our time. I will fix this and try to get it merged ASAP. |
bdlukaa
approved these changes
Feb 25, 2022
DriesCruyskens
added a commit
to DriesCruyskens/gotrue-dart
that referenced
this pull request
Mar 4, 2022
bdlukaa
approved these changes
Mar 15, 2022
dshukertjr
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
phone
,phone_confirmed_at
,emailed_confirmed_at
to User.toJson()confirmed_at
- from User.toJson()Additional context
N/a