Skip to content
This repository has been archived by the owner on May 13, 2023. It is now read-only.

Misc Enhancements #43

Merged
merged 4 commits into from
Mar 16, 2022
Merged

Misc Enhancements #43

merged 4 commits into from
Mar 16, 2022

Conversation

HarryET
Copy link
Contributor

@HarryET HarryET commented Oct 30, 2021

What kind of change does this PR introduce?

What is the current behavior?

  • Missing Slack & Spotify Providers
  • Missing keys in User.toJson()

What is the new behavior?

  • Includes Slack & Spotify
  • Adds missing keys - phone, phone_confirmed_at, emailed_confirmed_at to User.toJson()
  • Removed old key - confirmed_at - from User.toJson()

Additional context

N/a

Rename `confirmed_at` so that email and phone confirmed at can be added. Also add the phone number field.
@HarryET HarryET marked this pull request as ready for review October 30, 2021 11:11
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for an amazing PR 🎉🎉🎉

I did leave a comment about one little thing. Please let me know what you think!

lib/src/user.dart Show resolved Hide resolved
@DriesCruyskens
Copy link

Any estimate to when this will be merged?

@dshukertjr
Copy link
Member

Sorry @DriesCruyskens for taking our time. I will fix this and try to get it merged ASAP.

DriesCruyskens added a commit to DriesCruyskens/gotrue-dart that referenced this pull request Mar 4, 2022
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dshukertjr dshukertjr merged commit cb0d042 into supabase:main Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing keys in User.toJson()
4 participants