Skip to content
This repository has been archived by the owner on May 13, 2023. It is now read-only.

Add base implementation of native openID connect #61

Merged
merged 5 commits into from
Feb 28, 2022
Merged

Add base implementation of native openID connect #61

merged 5 commits into from
Feb 28, 2022

Conversation

DanMossa
Copy link
Contributor

@DanMossa DanMossa commented Feb 28, 2022

This pretty much overtakes this PR in draft
https://github.com/supabase-community/gotrue-dart/pull/57/files

I basically rewrote https://github.com/supabase/gotrue-js/pull/207/files in dart.

Once this is merged in I need to update Supabase
Which will then require me to update https://github.com/supabase-community/supabase-flutter

Copy link
Contributor

@bdlukaa bdlukaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format files using dart format .

lib/src/opent_id_connect_credentials.dart Outdated Show resolved Hide resolved
lib/src/opent_id_connect_credentials.dart Outdated Show resolved Hide resolved
lib/src/gotrue_client.dart Show resolved Hide resolved
@DanMossa
Copy link
Contributor Author

DanMossa commented Feb 28, 2022

Great! You can go ahead and merge when you're ready @bdlukaa .
This fixes #27
and let's me get started on
supabase/supabase-flutter#5

@bdlukaa bdlukaa merged commit 041674d into supabase:main Feb 28, 2022
@bdlukaa bdlukaa mentioned this pull request Feb 28, 2022
@DanMossa
Copy link
Contributor Author

@bdlukaa What's the process of bumping this to a new version so it can be used in supabase-dart?

@bdlukaa
Copy link
Contributor

bdlukaa commented Feb 28, 2022

@dshukertjr usually do the releases of all dart packages. for now, you can use git and path dependencies

@hmarat
Copy link

hmarat commented Aug 24, 2022

@bdlukaa I do in this way, but I see null logs anywhere(except my idToken got with google_sign_in)
image

I don't know what's wrong here. Configs also are done correctly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants