This repository has been archived by the owner on May 13, 2023. It is now read-only.
BREAKING: user will be returned when signing up with auto confirm off #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a breaking change, correct? |
|
@DanMossa Yup, it is. Thanks for flagging it! |
dshukertjr
changed the title
bdlukaa
approved these changes
Mar 3, 2022
|
I agree with this behavior. There is a flag to check if the email isn't verified, which allows this behavior to be acceptable |
DanMossa
approved these changes
Mar 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, with the Dart SDK, when a user signs up and the auto confirm is turned off, the SDK does not returns null for both user and session. This is not the case in js library, so this PR attempts to follow the same behavior in Dart SDK as well.
Closes #54
Closes supabase/supabase-flutter#39