Skip to content
This repository has been archived by the owner on May 13, 2023. It is now read-only.

Add generateLink method #83

Merged
merged 5 commits into from
Jul 29, 2022
Merged

Add generateLink method #83

merged 5 commits into from
Jul 29, 2022

Conversation

NiKoTron
Copy link
Contributor

Added generateLink method reffer to the supabase's Auth(Server only) API

+ InviteType enumeration
+ API's generateLink() method
@bdlukaa
Copy link
Contributor

bdlukaa commented Jul 19, 2022

I'm not sure we want to expose server APIs to this client library

@dshukertjr

@NiKoTron
Copy link
Contributor Author

why not? For example, I use dart as a server language. Also there's api key based restriction to use this method, i guess it should be enough.

@dshukertjr
Copy link
Member

@bdlukaa I was the one who said let's wait on implementing server side methods on these libraries, because I thought the js library was going to be separated into client side library and server side library on this issue, it hasn't been separated and I checked with the team, but it seems like we don't have immediate plans to separate it (still on the road map at some point though).

With Dart increasing in popularity as a server side language, perhaps we could reconsider it and start adding all the server side methods?

Related #26

@dshukertjr
Copy link
Member

@NiKoTron Could we include a test as well for this amazing work that you have done?
https://github.com/supabase/gotrue-js/blob/master/test/GoTrueApi.test.ts#L294

+ added dev dependency jsonwebtoken to generate server token
@NiKoTron
Copy link
Contributor Author

@dshukertjr Sorry for the late reply. I made tests similiar to JS impl. also added dart_jsonwebtoken as a dev_dependency to geneate service jwt.

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NiKoTron Looks amazing! The momentum of server side dart community is amazing!

@dshukertjr dshukertjr merged commit e01d051 into supabase:main Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants