This repository has been archived by the owner on May 13, 2023. It is now read-only.
fix: don't require session after signup #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshukertjr
reviewed
Aug 12, 2022
There was a problem hiding this comment.
Thanks for the quick and amazing work here!
Could we also fix this test to check if session is null but user exists and remove the try/catch?
I think it's okay to add the property of GotrueSessionResponse to session from data update in this PR as well!
|
I see that |
|
@Vinzent03 |
dshukertjr
approved these changes
Aug 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes supabase/supabase-flutter#182
See my comment for a question regarding the sign in event and strange naming of
data.