Skip to content
This repository has been archived by the owner on May 13, 2023. It is now read-only.

fix: properly add redirect_to when making request #96

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

dshukertjr
Copy link
Member

What kind of change does this PR introduce?

Currently, redirect_to parameter of the request method is being URI encoded twice, resulting in wrong value being passed as the query parameter. This PR fixes it.

Fixes supabase/supabase-flutter#244

What is the current behavior?

Because redirect_to is not being passed properly, emailRedirectTo is not working

What is the new behavior?

emailRedirectTo should be working with this one.

@dshukertjr dshukertjr requested a review from a team October 22, 2022 04:59
@dshukertjr dshukertjr mentioned this pull request Oct 22, 2022
@Vinzent03
Copy link
Contributor

Where is it encoded the second time?

@Vinzent03
Copy link
Contributor

Ah the Uri constructor already handles this. https://api.dart.dev/stable/2.18.3/dart-core/Uri/Uri.html

@dshukertjr dshukertjr merged commit d3e0b3f into main Oct 22, 2022
@dshukertjr dshukertjr deleted the fix/redirect_to branch October 22, 2022 11:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with redirect url in v1.0.0
2 participants