Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup typescript usage #9

Merged

Conversation

sduduzog
Copy link
Collaborator

What kind of change does this PR introduce?

  • Fixes missing type from the vue instance exposed to nuxt
  • Adds details into setting up the module for TypeScript usage

What is the current behavior?

What is the new behavior?

image

@jannikbuscha
Copy link

image
I get this message when i use the property-decorator. But it worked. Do you know how i can remove this message?

@scottrobertson
Copy link
Contributor

image

I get this message when i use the property-decorator. But it worked. Do you know how i can remove this message?

Are you running on this branch?

@jannikbuscha
Copy link

image
I get this message when i use the property-decorator. But it worked. Do you know how i can remove this message?

Are you running on this branch?

yes

@scottrobertson
Copy link
Contributor

scottrobertson commented Aug 22, 2021

Thanks @jannikbuscha

@sduduzog this ready to go? What changes need to be done to resolve ^?

@sduduzog
Copy link
Collaborator Author

sduduzog commented Aug 25, 2021

Thanks @jannikbuscha

@sduduzog this ready to go? What changes need to be done to resolve ^?

Probably some research needs to be done in how 'vue-class-component' works and how types work there. I hope it's as simple as the changes done for nuxt... I'll look into it when I get the chance...

But yes, this PR specifically is ready to go.

@jannikbuscha please could you create a seperate issue for the types issue with class components

@scottrobertson scottrobertson merged commit fe789ec into supabase-community:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants