Skip to content
This repository has been archived by the owner on May 13, 2023. It is now read-only.

fix: maybeSingle #84

Merged
merged 9 commits into from Aug 24, 2022
Merged

fix: maybeSingle #84

merged 9 commits into from Aug 24, 2022

Conversation

Vinzent03
Copy link
Contributor

@Vinzent03 Vinzent03 commented Aug 21, 2022

There were multiple problems:

  1. Parsing of the error failed, because hint was missing
  2. data was not null, but an empty string?
  3. On null it returned a PostgrestResponse instead of data directly, because count was not null.

fix supabase/supabase-flutter/issues/195

@Vinzent03
Copy link
Contributor Author

I only have flutter channel beta and stable installed. Looks like the formatter changes in the latest dart release.

lib/src/types.dart Outdated Show resolved Hide resolved
@Vinzent03 Vinzent03 requested a review from a team August 21, 2022 16:30
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vinzent03 Sorry for taking my time to review this one!

Thank you so much for the quick fix here! I just had few small questions, but it all looks amazing!

.github/workflows/main.yml Show resolved Hide resolved
test/transforms_test.dart Show resolved Hide resolved
test/basic_test.dart Show resolved Hide resolved
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing to me! Looks like the failing tests is just the formatting rule changing in dev branch of dart, so let's merge it in!

Could we update the package version number, changelog, and version.dart as well?

@Vinzent03
Copy link
Contributor Author

@dshukertjr I will fix supabase/supabase-flutter/issues/201 today as well, so please wait with release.

@dshukertjr
Copy link
Member

Cool, merging this one then!

@dshukertjr dshukertjr merged commit 8d71fb1 into supabase:master Aug 24, 2022
@Vinzent03 Vinzent03 deleted the issue195 branch August 24, 2022 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maybeSingle throws exception when no results returned
3 participants