Skip to content
This repository has been archived by the owner on May 13, 2023. It is now read-only.

fix/contains list #85

Merged
merged 13 commits into from Aug 26, 2022
Merged

fix/contains list #85

merged 13 commits into from Aug 26, 2022

Conversation

Vinzent03
Copy link
Contributor

@Vinzent03 Vinzent03 marked this pull request as draft August 24, 2022 12:52
@Vinzent03
Copy link
Contributor Author

@dshukertjr I'm confused, whether an array needs to be {} or (). I've tested all filters in the newest commit and all needed the {} format. Except in. That's the only one I've found that needs ().

@dshukertjr
Copy link
Member

@Vinzent03
Hmm, so it seems like there was a breaking change on Postgrest huh? Let me check...

@Vinzent03
Copy link
Contributor Author

Vinzent03 commented Aug 25, 2022

I think I would have noticed this, but may we upgrade the postgrest version in the tests?

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vinzent03
Sorry, got caught up with other things and couldn't come back to this one until now.

I have updated the docker-compose to what is used in postgrest-js here #86. We could probably merge this one in and re-run the tests on this branch!

Thanks for checking different filters and figuring out which filter needs which brackets. I think the Dart library just had the wrong type of brackets until now and there was no breaking change on the Postgrest's end.

@Vinzent03 Vinzent03 marked this pull request as ready for review August 26, 2022 08:40
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the amazing work! I just had one little thing, but it all looks fantastic 🎉

test/filter_test.dart Show resolved Hide resolved
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update! Wow, there were lot more than I thought! It looks amazing🎉

@dshukertjr dshukertjr merged commit bc0db3a into supabase:master Aug 26, 2022
@Vinzent03 Vinzent03 deleted the issue201 branch August 26, 2022 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using string array in filter query not working as expected
2 participants