New execute method for json objects #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR implements a new
executeTo
method which automatically parses the response into a json object as described in #7What is the current behavior?
#7
What is the new behavior?
An
ExecuteTo
method was added to the structs as described which directly parses the response body into aninterface{}
Additional context
I tried to implement the changes described in the issue but was not sure regarding the requriements. I currently implemented the functions as requested with the return value of an
(interface{}, error)
for theExecuteTo
functions.I also thought about changing the function to
ExecuteTo(target interface{}) error
which enables the user to give a custom struct or map from outside. Then instead of creating a new object inside theexecuteTo
function, this target value is used to parse the response body into. I would be open to implement this function as well - maybe under a different name likeExecuteInto
As this is my first contribution, i hope i didn't miss something or did something wrong, if so please let me know so i can fix it!