Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "and" logical operator #42

Merged
merged 1 commit into from Jan 8, 2024

Conversation

icepuma
Copy link
Contributor

@icepuma icepuma commented Dec 23, 2023

What kind of change does this PR introduce?

- doc: https://postgrest.org/en/stable/references/api/tables_views.html#logical-operators
- hint: couldn't find the documentation if "$foreignTable.and" is supported like "$foreignTable.or"

- doc: https://postgrest.org/en/stable/references/api/tables_views.html#logical-operators
- hint: couldn't find the documentation if "$foreignTable.and" is supported like "$foreignTable.or"
@muratmirgun
Copy link
Member

@icepuma thanks for first contributions I will look your pr

@muratmirgun muratmirgun self-requested a review January 5, 2024 11:16
@muratmirgun
Copy link
Member

Hello Again I check docs and look for an example but I can't find one. Can you check and test with Postgrest from compose file in main folder and look again please if you need sample data you can check here: https://www.databasestar.com/sample-bookstore-database/

@icepuma
Copy link
Contributor Author

icepuma commented Jan 7, 2024

Hey,
there's two things I added. The and operator and the $foreignTable.and. The and operator is documented at the link I shared. The second operator is "documented" here where children.and= should be the case for the second "operator".

@muratmirgun
Copy link
Member

Okay, Thanks I merge it 🚀

@muratmirgun muratmirgun merged commit f84277b into supabase-community:main Jan 8, 2024
1 check passed
Copy link
Member

@muratmirgun muratmirgun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants