Skip to content

Commit

Permalink
fix-sanitize_param-double-quote-error (#61)
Browse files Browse the repository at this point in the history
* replace utf-8 character by character

* avoid escaping characters by using single quotes

* fix tests
  • Loading branch information
dreinon committed Jan 3, 2022
1 parent a936820 commit 0eb871a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion postgrest_py/utils.py
Expand Up @@ -13,7 +13,7 @@ def sanitize_param(param: Any) -> str:
param_str = str(param)
reserved_chars = ",.:()"
if any(char in param_str for char in reserved_chars):
return f"%22{param_str}%22"
return f'"{param_str}"'
return param_str


Expand Down
6 changes: 3 additions & 3 deletions tests/_async/test_filter_request_builder.py
Expand Up @@ -16,19 +16,19 @@ def test_constructor(filter_request_builder):
assert builder.path == "/example_table"
assert builder.http_method == "GET"
assert builder.json == {}
assert builder.negate_next == False
assert not builder.negate_next


def test_not_(filter_request_builder):
builder = filter_request_builder.not_

assert builder.negate_next == True
assert builder.negate_next


def test_filter(filter_request_builder):
builder = filter_request_builder.filter(":col.name", "eq", "val")

assert builder.session.params["%22:col.name%22"] == "eq.val"
assert builder.session.params['":col.name"'] == "eq.val"


def test_multivalued_param(filter_request_builder):
Expand Down
6 changes: 3 additions & 3 deletions tests/_sync/test_filter_request_builder.py
Expand Up @@ -16,19 +16,19 @@ def test_constructor(filter_request_builder):
assert builder.path == "/example_table"
assert builder.http_method == "GET"
assert builder.json == {}
assert builder.negate_next == False
assert not builder.negate_next


def test_not_(filter_request_builder):
builder = filter_request_builder.not_

assert builder.negate_next == True
assert builder.negate_next


def test_filter(filter_request_builder):
builder = filter_request_builder.filter(":col.name", "eq", "val")

assert builder.session.params["%22:col.name%22"] == "eq.val"
assert builder.session.params['":col.name"'] == "eq.val"


def test_multivalued_param(filter_request_builder):
Expand Down

0 comments on commit 0eb871a

Please sign in to comment.