maybe_single with no matching rows returns None (#231)

supabase-community · Mar 7, 2023 · d148298 · d148298
1 parent 67572ba
commit d148298
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 16 deletions.
diff --git a/postgrest/_async/request_builder.py b/postgrest/_async/request_builder.py
@@ -122,19 +122,13 @@ async def execute(self) -> SingleAPIResponse:
 
 
 class AsyncMaybeSingleRequestBuilder(AsyncSingleRequestBuilder):
-    async def execute(self) -> SingleAPIResponse:
+    async def execute(self) -> Optional[SingleAPIResponse]:
         r = None
         try:
             r = await super().execute()
         except APIError as e:
             if e.details and "Results contain 0 rows" in e.details:
-                return SingleAPIResponse.from_dict(
-                    {
-                        "data": None,
-                        "error": None,
-                        "count": 0,  # NOTE: needs to take value from res.count
-                    }
-                )
+                return None
         if not r:
             raise APIError(
                 {

diff --git a/postgrest/_sync/request_builder.py b/postgrest/_sync/request_builder.py
@@ -122,19 +122,13 @@ def execute(self) -> SingleAPIResponse:
 
 
 class SyncMaybeSingleRequestBuilder(SyncSingleRequestBuilder):
-    def execute(self) -> SingleAPIResponse:
+    def execute(self) -> Optional[SingleAPIResponse]:
         r = None
         try:
             r = super().execute()
         except APIError as e:
             if e.details and "Results contain 0 rows" in e.details:
-                return SingleAPIResponse.from_dict(
-                    {
-                        "data": None,
-                        "error": None,
-                        "count": 0,  # NOTE: needs to take value from res.count
-                    }
-                )
+                return None
         if not r:
             raise APIError(
                 {