Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit #28

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Add pre-commit #28

merged 3 commits into from
Oct 27, 2021

Conversation

anand2312
Copy link
Contributor

This PR adds basic pre-commit configuration to force pythonic style on the codebase. I have also updated the README to include the pre-commit install step.

dreinon
dreinon approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@dreinon dreinon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@lqmanh
Copy link
Collaborator

lqmanh commented Oct 27, 2021

@anand2312 Great feature, thank you!
Could you please add this Prettier hook. It helps auto-formatting non-code files like .md, .yaml,...

@lqmanh lqmanh merged commit c5032b5 into supabase-community:master Oct 27, 2021
@anand2312 anand2312 deleted the add-precommit branch October 27, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreinon dreinon dreinon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anand2312 @lqmanh @dreinon