Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout #417

Merged
merged 1 commit into from Apr 29, 2024
Merged

Conversation

juancarlospaco
Copy link
Contributor

What kind of change does this PR introduce?

  • Increase timeout, from 5 to 120. See the link below.

Additional context

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @juancarlospaco - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@@ -3,4 +3,4 @@
"Content-Type": "application/json",
}

DEFAULT_POSTGREST_CLIENT_TIMEOUT = 5
DEFAULT_POSTGREST_CLIENT_TIMEOUT = 120
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): Consider the implications of increasing the timeout to 120 seconds.

This change significantly increases the client timeout, which might affect system performance and user experience. Ensure that this adjustment is justified by the specific needs of the application and consider documenting the rationale behind such a significant change.

@J0
Copy link
Contributor

J0 commented Apr 29, 2024

Thank you!

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.91%. Comparing base (b858685) to head (1aaa3ac).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
+ Coverage   95.72%   95.91%   +0.18%     
==========================================
  Files          28       28              
  Lines        1639     1715      +76     
==========================================
+ Hits         1569     1645      +76     
  Misses         70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silentworks silentworks merged commit a387471 into supabase-community:master Apr 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants