Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes simplify #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes simplify #148

wants to merge 1 commit into from

Conversation

juancarlospaco
Copy link
Contributor

What kind of change does this PR introduce?

  • Simplify code from too long elif-chain into a dict.
  • Try to improve cyclomatic complexity and hopefully performance.
  • Add docs.

@juancarlospaco juancarlospaco requested a review from a team as a code owner May 20, 2024 22:24
sourcery-ai[bot]
sourcery-ai bot reviewed May 20, 2024
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@juancarlospaco