-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental support for IOS native target #53
Conversation
815b1c5
to
7859cf4
Compare
a54a7c8
to
66b7ab1
Compare
7756849
to
30a1a68
Compare
Published a version (0.8.0-beta-2-ios) with support for IOS, testing would be appreciated! If you also can test deep linking, the syntax is the same as Android but with URL Schemes |
For what it's worth, I've been testing this a bit in my own app and have not had any issues on the iOS side - things look great. Haven't had the chance to test deep linking though |
Great! Once the deep linking is settled, I'll merge this PR. I'm unsure about one thing: On Android supabase-kt pause and resumes auto refresh for the GoTrue session. Should this also be done on IOS/how would one implement this on IOS (using Kotlin of course)? |
@jan-tennert could you please add the support for Arm64 simulator targets? |
49d2f91
to
ae8a5e6
Compare
3932891
to
9d9244d
Compare
@seankcw @jollygreenegiant Did anyone get the chance to test out deeplinking? |
@jan-tennert I tested 0.8.5 I can successfully log in with my account, but I haven't tested the deep linking on client-side project, because I'm doing deeplink/token verification in KMM directly (with MVI pattern). |
Alright, thanks! Then I'll merge this PR for now |
I was testing it, but when deeplink is handled, in URL object are data, but method handleDeeplink don't save data. When I am calling on Android is working well. |
Couldnt test out deeplinking as I stated. Can you print out |
here is output from fragment.url print: |
Okay that looks alright, I published a dev version |
I added |
Okay so you can try to print out supabase-kt/GoTrue/src/iosMain/kotlin/io/github/jan/supabase/gotrue/IOS.kt Lines 11 to 14 in 3bde3ad
|
ok, you have right, I had wrong configuration in GoTrue, I changed it for correct one, but I am getting exception right now. |
are you using the darwin ktor engine for ios? If not, try it |
really thanks for help, it helped :) |
No problem! I'll add additional information to the troubleshooting page |
What kind of change does this PR introduce?
Feature
What is the current behavior?
No support for IOS
What is the new behavior?
Support for iosArm64, iosSimulatorArm64, and iosX64 including deeplinking (syntax same as android)
Additional context
I cannot really test this PR as I don't have Mac myself to run a IOS Emulator on. I'm also not really familiar with IOS programming. Help would be appreciated
If you want to help, there is a version supporting IOS:
0.8.5-ios
Currently needed: Feedback for deeplinking
To enable deeplinking, setup an URL Scheme
and set the host & scheme in the gotrue plugin:
And on startup, call
client.handleDeeplinks(url)