Replaced makefile with poetry scripts #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, fixed that up. Not sure how i missed that. Must have been when I swapped between using poe and the builtin scripts |
J0
approved these changes
Oct 17, 2022
Codecov ReportBase: 82.26% // Head: 78.37% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #287 +/- ##
===========================================
- Coverage 82.26% 78.37% -3.90%
===========================================
Files 8 9 +1
Lines 141 148 +7
===========================================
Hits 116 116
- Misses 25 32 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced makefile with poetry scripts.
@J0 , @dreinon is this something like you had in mind? I'm not really a fan of how you end up with the
poetry_scripts.pyat the top level. But it seems like there isn't really a consensus on how you should do this - python-poetry/poetry#2496LMK if you had envisaged it somewhat differently/had a better example.
Fixes #102