Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gotrue): ignore 401 and 404 errors on sign out #179

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

grdsdev
Copy link
Collaborator

@grdsdev grdsdev commented Dec 6, 2023

What kind of change does this PR introduce?

Fix #176

What is the current behavior?

When the user is deleted through Admin, the call to signOut on the client fails and the user doesn't log out locally because it returns a 404.

What is the new behavior?

Ignore 404 and 401 errors when signing out, which will ensure to always log out the user locally.

@grdsdev grdsdev changed the title fix: ignore 401 and 404 errors on sign out fix(gotrue): ignore 401 and 404 errors on sign out Dec 6, 2023
@grdsdev grdsdev self-assigned this Dec 6, 2023
@grdsdev grdsdev enabled auto-merge (squash) December 7, 2023 20:43
@grdsdev grdsdev merged commit 2ebf6e2 into main Dec 7, 2023
2 checks passed
@grdsdev grdsdev deleted the fix/ignore-some-signout-errors branch December 7, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow sign out after deleting user
1 participant