You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would like to add ".local" to the list of hosts checked in src/lib/cookies.js
Is your feature request related to a problem? Please describe.
The problem I am facing is when developing a multi-tenanted application in my local environment, I define the tenant in my hosts file as tenant-name.application.local.
The isSecureEnvironment method in src/lib/cookies.js checks the host header to include 127.0.0.1 and localhost which returns false, causing the cookie to be set as Secure:
Describe the solution you'd like
I would like to add ".local" to the list of hosts checked in src/lib/cookies.js
Describe alternatives you've considered
Changing my hosts file to use tenant-name.application.localhost, however when accessing the application from other machines on the network it might be confusing, calling a remote host that ends with .localhost.
I believe the .local tld is fairly commonly used to resolve a machine on your local network.
Additional context
Adding ".local" to the array might return some false positives due to the way the values are checked.
EG: [".local", ...].includes(host) would return true for the fictional vhost: app.localbusiness.com.
Maybe it would be better suited to change the check from:
Feature request
I would like to add
".local"
to the list of hosts checked insrc/lib/cookies.js
Is your feature request related to a problem? Please describe.
The problem I am facing is when developing a multi-tenanted application in my local environment, I define the tenant in my hosts file as
tenant-name.application.local
.The
isSecureEnvironment
method insrc/lib/cookies.js
checks the host header to include127.0.0.1
andlocalhost
which returnsfalse
, causing the cookie to be set as Secure:Describe the solution you'd like
I would like to add
".local"
to the list of hosts checked insrc/lib/cookies.js
Describe alternatives you've considered
Changing my hosts file to use tenant-name.application.localhost, however when accessing the application from other machines on the network it might be confusing, calling a remote host that ends with
.localhost
.I believe the
.local
tld is fairly commonly used to resolve a machine on your local network.Additional context
Adding
".local"
to the array might return some false positives due to the way the values are checked.EG:
[".local", ...].includes(host)
would return true for the fictional vhost:app.localbusiness.com
.Maybe it would be better suited to change the check from:
To:
Would be better suited.
The text was updated successfully, but these errors were encountered: