Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still having getSession warning whenever _saveSession is called #912

Open
2 tasks done
larbish opened this issue May 17, 2024 · 6 comments
Open
2 tasks done

Still having getSession warning whenever _saveSession is called #912

larbish opened this issue May 17, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@larbish
Copy link

larbish commented May 17, 2024

Bug report

  • I confirm this is a bug with Supabase, not with my own application.
  • I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

Maintainer of the nuxt/supabase module here.

We have a PR to migrate on the @supabase/ssr package and we're still experiencing this issue with the latest released version including your PR.

The module is now using the @supabase/ssr package and we're still experiencing this issue with the latest released version.

I've removed all occurrences of getSession() in the module and I still have the warning.

Any help on this would be appreciate 🙏

To Reproduce

Clone the nuxt/supabase repository and follow the development readme to run the playground.

Notice the Using the user object as returned from supabase.auth.getSession() or from some supabase.auth.onAuthStateChange() events could be insecure warning.

Expected behavior

Do not display this warning.

@larbish larbish added the bug Something isn't working label May 17, 2024
@j4w8n
Copy link
Contributor

j4w8n commented May 26, 2024

Have you heard back about this?

@regg00
Copy link

regg00 commented Jun 7, 2024

@larbish, you got any news about this issue?

@larbish
Copy link
Author

larbish commented Jun 18, 2024

No news about it so far... @thorwebdev could someone have a check at this please? I'd love to merge my PR in the module and use @supabase/ssr package 🙏

@hf
Copy link
Contributor

hf commented Jun 19, 2024

We'll check this as soon as we can. Any external help in tracking down where the use comes from would help speed it up.

@j4w8n
Copy link
Contributor

j4w8n commented Jun 19, 2024

Looks like the code calls session.user a couple of times. And it json stringifies the session as well, which would also trigger the warning.

@scottandrew
Copy link

I am seeing this constantly right now ever since updating to SSR 0.4.0 and following the documentation. Going back to SSR 0.3.0 this seems to git rid of the messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants