Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid HELO message for smtp relays - w/Solution Proposal #1502

Closed
2 tasks done
saschTa opened this issue Mar 27, 2024 · 1 comment
Closed
2 tasks done

Invalid HELO message for smtp relays - w/Solution Proposal #1502

saschTa opened this issue Mar 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@saschTa
Copy link

saschTa commented Mar 27, 2024

Bug report

  • I confirm this is a bug with Supabase, not with my own application.
  • I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

Supabase Auth uses supabase/mailme with gomail for sending emails over external smtp servers.

Gomail uses localhost as default HELO message which gets rejected by some smtp providers. (gmail smtp relay e.g.)
Gomail might change that behaviour but I think supabase should not use a default value here.
go mail pr

Additional context - Linked Issue

I created an issue on supabase general already since I was not sure where the culprit was located.
After some digging I found the issue in mailme which is used by supabase/auth

I link the issue here and the pr in mailme for sake of completeness. Please let me know if we should move the issue here or to mailme.

Issue

PR for mailme

@kangmingtay
Copy link
Member

closing this issue since we've bumped the mailme package in this PR which contains the changes you've made!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants