Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add send email Hook #1512

Merged
merged 11 commits into from
Apr 4, 2024
Merged

feat: add send email Hook #1512

merged 11 commits into from
Apr 4, 2024

Conversation

J0
Copy link
Contributor

@J0 J0 commented Apr 2, 2024

What kind of change does this PR introduce?

The send email hook serves as a substitute for the default email client (e.g. GoMail) across all endpoints.

Supercedes #1496 as it was simpler to visualize the PR when starting from scratch

@J0 J0 requested a review from a team as a code owner April 2, 2024 16:12
@J0
Copy link
Contributor Author

J0 commented Apr 2, 2024

Reverting to draft to do some manual testing and maybe add a few automated tests

internal/api/mail.go Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Apr 2, 2024

Pull Request Test Coverage Report for Build 8555762112

Details

  • 34 of 71 (47.89%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 65.175%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/hooks.go 0 18 0.0%
internal/api/mail.go 34 53 64.15%
Files with Coverage Reduction New Missed Lines %
internal/api/hooks.go 1 53.91%
internal/api/mail.go 1 62.94%
Totals Coverage Status
Change from base Build 8536116968: -0.2%
Covered Lines: 8055
Relevant Lines: 12359

💛 - Coveralls

internal/api/mail.go Show resolved Hide resolved
internal/mailer/mailer.go Outdated Show resolved Hide resolved
@J0 J0 merged commit cf42e02 into master Apr 4, 2024
2 checks passed
@J0 J0 deleted the j0/custom_email_hook branch April 4, 2024 13:51
J0 pushed a commit that referenced this pull request Apr 9, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.147.0](v2.146.0...v2.147.0)
(2024-04-05)


### Features

* add send email Hook
([#1512](#1512))
([cf42e02](cf42e02))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants