Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add validation and proper decoding on send email hook #1520

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

J0
Copy link
Contributor

@J0 J0 commented Apr 9, 2024

What kind of change does this PR introduce?

bug discovered while testing

@J0 J0 requested a review from a team as a code owner April 9, 2024 08:42
@coveralls
Copy link

coveralls commented Apr 9, 2024

Pull Request Test Coverage Report for Build 8613054506

Details

  • 2 of 5 (40.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 65.165%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/conf/configuration.go 2 5 40.0%
Totals Coverage Status
Change from base Build 8608559134: -0.01%
Covered Lines: 8057
Relevant Lines: 12364

💛 - Coveralls

@J0 J0 changed the title fix: add validation on send email hook fix: add validation and proper decoding on send email hook Apr 9, 2024
@J0 J0 merged commit e19e762 into master Apr 9, 2024
3 checks passed
@J0 J0 deleted the j0/validate_send_email branch April 9, 2024 10:22
J0 pushed a commit that referenced this pull request Apr 9, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.147.1](v2.147.0...v2.147.1)
(2024-04-09)


### Bug Fixes

* add validation and proper decoding on send email hook
([#1520](#1520))
([e19e762](e19e762))
* remove deprecated LogoutAllRefreshTokens
([#1519](#1519))
([35533ea](35533ea))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants