Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add array attribute mapping for SAML #1526

Merged
merged 1 commit into from
Apr 10, 2024
Merged

feat: add array attribute mapping for SAML #1526

merged 1 commit into from
Apr 10, 2024

Conversation

hf
Copy link
Contributor

@hf hf commented Apr 10, 2024

By adding the "array": true option in the JSON SAML attribute mapping document for a key, the SAML attribute(s) for that key will be represented as an array in the user identity claims.

@hf hf requested a review from a team as a code owner April 10, 2024 06:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8627235636

Details

  • 9 of 12 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 65.176%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/models/sso.go 0 3 0.0%
Totals Coverage Status
Change from base Build 8614802879: 0.004%
Covered Lines: 8059
Relevant Lines: 12365

💛 - Coveralls

Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the docs too once merged to reflect that this is possible.

@hf hf merged commit 7326285 into master Apr 10, 2024
3 checks passed
@hf hf deleted the hf/saml-array-values branch April 10, 2024 07:30
J0 pushed a commit that referenced this pull request Apr 10, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.148.0](v2.147.1...v2.148.0)
(2024-04-10)


### Features

* add array attribute mapping for SAML
([#1526](#1526))
([7326285](7326285))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants