feat: allow for postgres and http functions on each extensibility point #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8689095510Details
💛 - Coveralls |
J0
added a commit
that referenced
this pull request
Apr 12, 2024
## What kind of change does this PR introduce? In support of the use of HTTP Hook with Custom Access Token Extension Point. We need to take in a request in order to support the Custom Access Token Hook. We use the request in the Custom access hook depends on the request to fetch the global logger. We refactor `generateAccessToken` and a wrapping method, `issueRefreshToken`, to take in a request to support this. We also add a dummy request to the tests to support this change. Supports #1528 - branched out as a separate PR so as not to bloat the main PR with peripheral changes.
J0
force-pushed
the
j0/allow_postgres_and_http_on_extensibility_point
branch
from
88ba493
to
7b60d67
Compare
J0
commented
Apr 12, 2024
J0
commented
Apr 15, 2024
hf
approved these changes
Apr 15, 2024
hf
reviewed
Apr 15, 2024
J0
force-pushed
the
j0/allow_postgres_and_http_on_extensibility_point
branch
from
4311d7e
to
991ffa2
Compare
J0
force-pushed
the
j0/allow_postgres_and_http_on_extensibility_point
branch
from
991ffa2
to
f6f9b65
Compare
hf
pushed a commit
that referenced
this pull request
Apr 25, 2024
🤖 I have created a release *beep* *boop* --- ## [2.150.0](v2.149.0...v2.150.0) (2024-04-25) ### Features * add support for Azure CIAM login ([#1541](#1541)) ([1cb4f96](1cb4f96)) * add timeout middleware ([#1529](#1529)) ([f96ff31](f96ff31)) * allow for postgres and http functions on each extensibility point ([#1528](#1528)) ([348a1da](348a1da)) * merge provider metadata on link account ([#1552](#1552)) ([bd8b5c4](bd8b5c4)) * send over user in SendSMS Hook instead of UserID ([#1551](#1551)) ([d4d743c](d4d743c)) ### Bug Fixes * return error if session id does not exist ([#1538](#1538)) ([91e9eca](91e9eca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
After this change, users can opt to use either Postgres or HTTP functions on each extensibility/extension point. From an implementation standpoint, all new extension points must support both HTTP and Postgres functions