-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update linkedin issuer url #1536
Conversation
077aa1b
to
3cf3450
Compare
3cf3450
to
ab272c9
Compare
Pull Request Test Coverage Report for Build 8688222628Details
💛 - Coveralls |
🤖 I have created a release *beep* *boop* --- ## [2.149.0](v2.148.0...v2.149.0) (2024-04-15) ### Features * refactor generate accesss token to take in request ([#1531](#1531)) ([e4f2b59](e4f2b59)) ### Bug Fixes * linkedin_oidc provider error ([#1534](#1534)) ([4f5e8e5](4f5e8e5)) * revert patch for linkedin_oidc provider error ([#1535](#1535)) ([58ef4af](58ef4af)) * update linkedin issuer url ([#1536](#1536)) ([10d6d8b](10d6d8b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Combination of multiple commits. More context below: Fixes #1533 Attempting to signInWithOAuth with linkedin_iodc provider results in error 500 Attempting to signInWithOAuth with linkedin_iodc results in a successful login Error from Supabase Auth Logs: `oidc: id token issued by a different provider, expected \"https://www.linkedin.com\" got \"https://www.linkedin.com/oauth\"` fix: revert patch for linkedin_oidc provider error (#1535) Reverts #1534 Doesn't seem to work as expected. Directly testing against the API by calling `https://localhost:9999/?provider=linkedin_oidc will return a 404 error. fix: update linkedin issuer url (#1536) * Linkedin introduced a breaking change by changing the issuer url in their discover document from `https://linkedin.com` to `https://linkedin.com/oauth` * Fixes #1533, #1534, [#22711](https://github.com/orgs/supabase/discussions/22711), [#22708](https://github.com/orgs/supabase/discussions/22708) Please link any relevant issues here. Feel free to include screenshots if it includes visual changes. Add any other context or screenshots. chore(master): release 2.149.0 (#1532) :robot: I have created a release *beep* *boop* --- [2.149.0](v2.148.0...v2.149.0) (2024-04-15) * refactor generate accesss token to take in request ([#1531](#1531)) ([e4f2b59](e4f2b59)) * linkedin_oidc provider error ([#1534](#1534)) ([4f5e8e5](4f5e8e5)) * revert patch for linkedin_oidc provider error ([#1535](#1535)) ([58ef4af](58ef4af)) * update linkedin issuer url ([#1536](#1536)) ([10d6d8b](10d6d8b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Revert "Merge branch 'master' into j0/allow_postgres_and_http_on_extensibility_point" This reverts commit 4311d7e, reversing changes made to 32fd777.
@kangmingtay @J0 how did you guys validate which one works? From the error I receive when using signInWithOAuth it looks like you actually need to remove the
|
@omerhochman you can query the We rolled out the fix recently - do you mind trying again? |
@J0 it works! |
I have the latest version but still getting this error. "@supabase/ssr": "^0.3.0", |
@jonathanjm, same here. |
Still seeing issues with this:
|
What kind of change does this PR introduce?
Linkedin introduced a breaking change by changing the issuer url in their
discover document from
https://linkedin.com
tohttps://linkedin.com/oauth
Fixes Error when using oauth with provider linkedin_oidc - Error getting user profile from external provider #1533, fix: linkedin_oidc provider error #1534, #22711, #22708
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.