Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Azure CIAM login #1541

Merged
merged 2 commits into from
Apr 23, 2024
Merged

feat: add support for Azure CIAM login #1541

merged 2 commits into from
Apr 23, 2024

Conversation

hf
Copy link
Contributor

@hf hf commented Apr 17, 2024

Adds support for Azure's CIAM login. This is a special B2B Azure account separate from the typical tenant accounts and is meant to be used only when the expected issuer is set to the CIAM tenant.

@hf hf requested a review from a team as a code owner April 17, 2024 12:58
@hf hf changed the title Hf/add azure ciam feat: add support for Azure CIAM login Apr 17, 2024
@coveralls
Copy link

coveralls commented Apr 17, 2024

Pull Request Test Coverage Report for Build 8797672222

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 5 (40.0%) changed or added relevant lines in 1 file are covered.
  • 17 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 65.566%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/provider/azure.go 2 5 40.0%
Files with Coverage Reduction New Missed Lines %
internal/api/phone.go 2 86.96%
internal/hooks/auth_hooks.go 15 54.55%
Totals Coverage Status
Change from base Build 8693432544: -0.01%
Covered Lines: 8144
Relevant Lines: 12421

💛 - Coveralls

internal/api/provider/azure.go Outdated Show resolved Hide resolved
@kangmingtay
Copy link
Member

@hf it doesn't seem trivial to test this one out :/ might be good to add some links to the docs to show what the issuer is expected to look like?

Co-authored-by: Kang Ming <kang.ming1996@gmail.com>
@hf hf merged commit 1cb4f96 into master Apr 23, 2024
2 checks passed
@hf hf deleted the hf/add-azure-ciam branch April 23, 2024 12:18
hf pushed a commit that referenced this pull request Apr 25, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.150.0](v2.149.0...v2.150.0)
(2024-04-25)


### Features

* add support for Azure CIAM login
([#1541](#1541))
([1cb4f96](1cb4f96))
* add timeout middleware
([#1529](#1529))
([f96ff31](f96ff31))
* allow for postgres and http functions on each extensibility point
([#1528](#1528))
([348a1da](348a1da))
* merge provider metadata on link account
([#1552](#1552))
([bd8b5c4](bd8b5c4))
* send over user in SendSMS Hook instead of UserID
([#1551](#1551))
([d4d743c](d4d743c))


### Bug Fixes

* return error if session id does not exist
([#1538](#1538))
([91e9eca](91e9eca))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants